-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install.rdf for publishing #39
Conversation
I pushed similar commit to my fork at the same time ^^ We should add commits to this branch and when ready to merge, squash them all into a single one |
👍 |
|
Did you see http://echofox.github.io/ ? So, nope ! xD |
Alright 😆 |
Ah seems better than the other, just signed a new version ! Let's try it ! (don't need to be OS-specific actually) |
Working fine. |
We changed addon uuid but was it really necessary? |
Same UUID causes validation fail, so we have to change it. For the rest, well, it's just about copyright and stuff we wanted to change before... |
Ok, so I would suggest not "altering" more original addon: keep Echofon identity everywhere, and set Echofox/Echofox Team only as maintainers |
I agree but don't you think it would be better to have "Echofon Unofficial" as the name ? Since UUID is different, installing the new version will not replace the old one ! |
Ping @echofox-team/core for name again ^^ see @YoruNoHikage question ahead |
Original name was "Echofon for Firefox" ; so I suggest "Echofon for Firefox - unofficial" |
A bit long... Just saying :-° |
Well, time has flown and Firefox 44 is here, breaking stuff fixed with #36, so we have to make a release, preferably signed. So, we should go for Echofon Unofficial (simpler is better !) and Can you change this, maybe squash commits and merge ? Do you have time to do this ? |
I should have time to do it later today |
c3b70b3
to
2b30c93
Compare
Update install.rdf for publishing
Squashed commits and merged. |
... I may have made a mistake, trying signing from AMO pages
(not yet deleted) I may have blacklisted GUID echofon-unofficial@echofox-team ? 😞 Will we be able to sign addon with each of our personal accounts? or should we create a shared account on AMO for @echofox-team/core? |
We should test and sign before releasing/tagging it on GitHub. I'm on it ! EDIT : oh damn... We should totally create a shared account. |
@YoruNoHikage Chat on gitter? |
👍 |
As I was saying on #3, we have to change some info for publishing.
First, ID, I change it to
echofox@echofox-team
since we do not have any domain/mail.Second, the name, well it's Echofox, no problem here.
Third, version : 2.6 seems right to me since it's not a major release but not just a fix.
What about the rest ? Any thoughts ?