Fix docx header issue #2026 #2068
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
speckyspooky
requested changes
Feb 28, 2025
...itter.wpml/src/org/eclipse/birt/report/engine/emitter/wpml/writer/AbstractWordXmlWriter.java
Show resolved
Hide resolved
...itter.wpml/src/org/eclipse/birt/report/engine/emitter/wpml/writer/AbstractWordXmlWriter.java
Show resolved
Hide resolved
...t.engine.emitter.docx/src/org/eclipse/birt/report/engine/emitter/docx/writer/DocxWriter.java
Outdated
Show resolved
Hide resolved
|
The solution looks good, I understand your way. Sometimes I think I'm deep on it but you are deeper (much deeper). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The showHeaderOnFirst property did not work for the DOCX emitter when using the combined RunAndRenderTask.
That is, the header was shown on the first page even when the property was false).
This PR makes this work.
It works with RunAndRenderTask as well as with separate RunTask and RenderTask.
The related property showFooterOnLast does not work with RunAndRenderTask,
only with separate RunTask and RenderTask.