Implement "Try new editing experience" to promote CDT LSP #421

jonahgraham · 2025-02-17T04:15:41Z

Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor:

And in the CLspEditor it enables a quick switch back to the traditional CEditor.

If there is no project specific setting for prefer_lsp a quick confirmation dialog is displayed with options for help and feedback:

and the other way:

If the editor is open on a specific project and that project has project specific preferences for prefer_lsp, instead of automatically changing the setting, the property page is opened:

A notification is also displayed to the user for a short while after the editors are re-opening offering more information and access to the preferences.

A notification is also displayed when closing the banner allowing the user easy access to disable opening the banner on new editors

Finally a new preference is available:

Fixes eclipse-cdt/cdt#968

jonahgraham · 2025-02-17T04:25:10Z

@ghentschke you can have an early look at this - I really want to get this into M3, which means latest Wednesday. This is still in draft mode and requires the corresponding CDT change eclipse-cdt/cdt#1088 so that we can hook into CEditor.

ghentschke · 2025-02-17T06:47:21Z

Yes, I'll take look at it.

bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/internal/switchtolsp/SwitchToLsp.java

ghentschke · 2025-02-17T07:37:17Z

Add preference to disable the banners in the editors and connect the close banner to it.

I think this is important to give vendors the possibility to disable the banners.

jonahgraham · 2025-02-19T02:19:23Z

@ghentschke / other interested parties

Please have a look - I updated the original description with updated and additional screenshots. eclipse-cdt/cdt#968 also has some of the older dark mode screenshots.

...g.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/internal/switchtolsp/ISwitchBackToTraditional.java

ghentschke · 2025-02-19T12:56:01Z

bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/internal/switchtolsp/SwitchToLsp.java

+ * SPDX-License-Identifier: EPL-2.0
+ *******************************************************************************/
+
+package org.eclipse.cdt.lsp.internal.switchtolsp;


I still cannot run/compile this change, because of this missing dependency which comes only with the CDT PR 1088

I don't know how we could avoid this break.

I also retested by building this patch with mvn verify and installing it into 2024-12 C/C++. The banner appears on CDT LSP editor, and not on CEditor.

Okay, the compiled jar file is executable in conjunction with CDT version < 12?

Yes. Cdt 12 is required for build, older cdt works at runtime.

If it is a hard requirement to build with cdt 11 we can ditch osgi for just that interface, and use a Function instead as the interface between CEditor and lsp

Lmk

No, its just important for us at run time because we cannot update our IDE at the moment and I still want to use the cdt-lsp latest builds.

ghentschke

LGTM

ghentschke · 2025-02-19T13:17:58Z

On windows 11 I see a frame around the banner:

Is this intended?

jonahgraham · 2025-02-19T13:29:17Z

Not intended. I will spin it up on Windows to see what to do about it.

jonahgraham · 2025-02-19T15:44:06Z

Is this intended?

Now fixed.

Sadly SWT's emoji handling on Windows makes the sparkles less sparkly. Its not something I can fix. LMK if the sparkle emoji use should be removed on Windows, or even on all platforms.

jonahgraham · 2025-02-19T16:07:38Z

I tested on macOS and it all looks good there too.

ghentschke · 2025-02-19T16:40:50Z

I think the less sparkling banner is better than nothing. @jonahgraham thank you!

jonahgraham

I have squashed and rebased on main. Once the build reports back this will be merged and I will contribute a build to SimRel later today for 2025-03 M3

jonahgraham · 2025-02-19T17:33:06Z

bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/editor/EditorMetadata.java

+	 *
+	 * @since 3.0
+	 */
+	List<PreferenceMetadata<?>> defaults = List.of(//


@ruspl-afed to take advantage of #425 I added the defaults here too.

Wrong link - should have been #431

oops. I just merged #432

sorry, I wasn't aware that you are planning change exactly in the same area @jonahgraham

ghentschke · 2025-02-19T17:37:57Z

I think it would be nice to have #425 in that build as well. What about #410 @ruspl-afed ?

jonahgraham · 2025-02-19T17:47:55Z

I think it would be nice to have #425 in that build as well. What about #410 @ruspl-afed ?

+1.

Also now that #432 is merged, I'll rebase this change.

Contribute a banner to the CEditor and CLspEditor to promote the new C/C++ editing experience based on LSP. The banner in CEditor enables a quick switch to the LSP editor: ![image](https://github.com/user-attachments/assets/67a3c8d7-7ea5-4fa4-8384-debebc893233) And in the CLspEditor it enables a quick switch back to the traditional CEditor. ![image](https://github.com/user-attachments/assets/e508a726-f892-47da-92bd-a195bedc0dda) If there is no project specific setting for `prefer_lsp` a quick confirmation dialog is displayed with options for help and feedback: ![image](https://github.com/user-attachments/assets/7c33d4fe-69a8-4cf8-b1fb-7ca80e07020c) and the other way: ![image](https://github.com/user-attachments/assets/a69a87d8-4f32-4e58-a651-2583db50183e) If the editor is open on a specific project and that project has project specific preferences for `prefer_lsp`, instead of automatically changing the setting, the property page is opened: ![image](https://github.com/user-attachments/assets/16c2ce3b-5b62-4199-8392-5d6800f621c7) A notification is also displayed to the user for a short while after the editors are re-opening offering more information and access to the preferences. ![image](https://github.com/user-attachments/assets/e8d069de-0939-4503-8755-a130595570d0) A notification is also displayed when closing the banner allowing the user easy access to disable opening the banner on new editors ![image](https://github.com/user-attachments/assets/9f9a00ef-8957-4a8a-8a3d-9c804eee5b5e) Finally a new preference is available: ![image](https://github.com/user-attachments/assets/74d2d461-d219-465b-9276-e93f6720a9ed) Fixes eclipse-cdt/cdt#968

jonahgraham · 2025-02-19T18:01:30Z

I got a green tick - so I am going for the merge.

ghentschke reviewed Feb 17, 2025

View reviewed changes

bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/internal/switchtolsp/SwitchToLsp.java Outdated Show resolved Hide resolved

jonahgraham force-pushed the try-lsp branch from 3788677 to e5294fa Compare February 18, 2025 15:37

jonahgraham mentioned this pull request Feb 18, 2025

editors opened with IDE.openEditors don't persist restart if never activated eclipse-platform/eclipse.platform.ui#2805

Open

2 tasks

jonahgraham force-pushed the try-lsp branch from 8ee5f94 to 8f077f8 Compare February 19, 2025 02:10

jonahgraham marked this pull request as ready for review February 19, 2025 02:11

jonahgraham requested a review from ghentschke February 19, 2025 02:11

jonahgraham force-pushed the try-lsp branch from 8f077f8 to 332df12 Compare February 19, 2025 02:18

ghentschke requested changes Feb 19, 2025

View reviewed changes

...g.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/internal/switchtolsp/ISwitchBackToTraditional.java Show resolved Hide resolved

jonahgraham requested a review from ghentschke February 19, 2025 12:15

ghentschke reviewed Feb 19, 2025

View reviewed changes

ghentschke approved these changes Feb 19, 2025

View reviewed changes

jonahgraham force-pushed the try-lsp branch from 39920df to 004366c Compare February 19, 2025 17:30

jonahgraham commented Feb 19, 2025

View reviewed changes

jonahgraham mentioned this pull request Feb 19, 2025

Propose a way to evolve options API without bumping major version every time #410

Closed

jonahgraham force-pushed the try-lsp branch from 004366c to 537211a Compare February 19, 2025 17:54

jonahgraham merged commit dfe1635 into eclipse-cdt:main Feb 19, 2025
3 checks passed

jonahgraham deleted the try-lsp branch February 19, 2025 18:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement "Try new editing experience" to promote CDT LSP #421

Implement "Try new editing experience" to promote CDT LSP #421

jonahgraham commented Feb 17, 2025 •

edited

Loading

jonahgraham commented Feb 17, 2025

ghentschke commented Feb 17, 2025

ghentschke commented Feb 17, 2025

jonahgraham commented Feb 19, 2025

ghentschke Feb 19, 2025

ghentschke Feb 19, 2025

ghentschke Feb 19, 2025 •

edited

Loading

jonahgraham Feb 19, 2025

ghentschke Feb 19, 2025 •

edited

Loading

ghentschke left a comment

ghentschke commented Feb 19, 2025 •

edited

Loading

jonahgraham commented Feb 19, 2025

jonahgraham commented Feb 19, 2025

jonahgraham commented Feb 19, 2025

ghentschke commented Feb 19, 2025

jonahgraham left a comment

jonahgraham Feb 19, 2025

jonahgraham Feb 19, 2025

ruspl-afed Feb 19, 2025

ruspl-afed Feb 19, 2025

ghentschke commented Feb 19, 2025

jonahgraham commented Feb 19, 2025

jonahgraham commented Feb 19, 2025

Implement "Try new editing experience" to promote CDT LSP #421

Implement "Try new editing experience" to promote CDT LSP #421

Conversation

jonahgraham commented Feb 17, 2025 • edited Loading

jonahgraham commented Feb 17, 2025

ghentschke commented Feb 17, 2025

ghentschke commented Feb 17, 2025

jonahgraham commented Feb 19, 2025

ghentschke Feb 19, 2025

Choose a reason for hiding this comment

ghentschke Feb 19, 2025

Choose a reason for hiding this comment

ghentschke Feb 19, 2025 • edited Loading

Choose a reason for hiding this comment

jonahgraham Feb 19, 2025

Choose a reason for hiding this comment

ghentschke Feb 19, 2025 • edited Loading

Choose a reason for hiding this comment

ghentschke left a comment

Choose a reason for hiding this comment

ghentschke commented Feb 19, 2025 • edited Loading

jonahgraham commented Feb 19, 2025

jonahgraham commented Feb 19, 2025

jonahgraham commented Feb 19, 2025

ghentschke commented Feb 19, 2025

jonahgraham left a comment

Choose a reason for hiding this comment

jonahgraham Feb 19, 2025

Choose a reason for hiding this comment

jonahgraham Feb 19, 2025

Choose a reason for hiding this comment

ruspl-afed Feb 19, 2025

Choose a reason for hiding this comment

ruspl-afed Feb 19, 2025

Choose a reason for hiding this comment

ghentschke commented Feb 19, 2025

jonahgraham commented Feb 19, 2025

jonahgraham commented Feb 19, 2025

jonahgraham commented Feb 17, 2025 •

edited

Loading

ghentschke Feb 19, 2025 •

edited

Loading

ghentschke Feb 19, 2025 •

edited

Loading

ghentschke commented Feb 19, 2025 •

edited

Loading