Remove unnecessary done() call on ProgressMonitor

See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html
eclipse-equinox · Dec 3, 2024 · 5c48af9 · 5c48af9
1 parent 1a42e02
commit 5c48af9
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/.../src/org/eclipse/equinox/internal/p2/artifact/repository/CompositeArtifactRepository.java b/.../src/org/eclipse/equinox/internal/p2/artifact/repository/CompositeArtifactRepository.java
@@ -146,7 +146,6 @@ private void addChild(URI childURI, boolean save, IProgressMonitor monitor, bool
 		SubMonitor sub = SubMonitor.convert(monitor);
 		URI absolute = URIUtil.makeAbsolute(childURI, getLocation());
 		if (childrenURIs.contains(childURI) || childrenURIs.contains(absolute)) {
-			sub.done();
 			return;
 		}
 		childrenURIs.add(childURI);

diff --git a/...g/eclipse/equinox/internal/p2/artifact/repository/CompositeArtifactRepositoryFactory.java b/...g/eclipse/equinox/internal/p2/artifact/repository/CompositeArtifactRepositoryFactory.java
@@ -133,9 +133,6 @@ public IArtifactRepository load(URI location, int flags, IProgressMonitor monito
 		} catch (IOException e) {
 			String msg = NLS.bind(Messages.io_failedRead, location);
 			throw new ProvisionException(new Status(IStatus.ERROR, Activator.ID, ProvisionException.REPOSITORY_FAILED_READ, msg, e));
-		} finally {
-			if (monitor != null)
-				monitor.done();
 		}
 	}