Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use CI Friendly versions for the P2 maven build" #573

Conversation

HannesWell
Copy link
Member

This reverts commit 612c5fa.

Using this pattern breaks the Update to next release workflow:

This reverts it to use versions the default way again. Once Tycho is fixed we can revert this again.
Or we just keep it then, since due more usage of tycho-pomless the number of locations to change is very low now and the Update to next release workflow does it automatically any ways.

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an older Tycho release then or a SNAPSHOT version after it is fixed. Reverting a 2 year old commit seem not to be a proper fix.

Copy link

Test Results

  375 files  ±0    375 suites  ±0   43m 23s ⏱️ +55s
1 904 tests ±0  1 901 ✅ ±0  3 💤 ±0  0 ❌ ±0 
6 712 runs  ±0  6 703 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 5ab9615. ± Comparison against base commit 65348d6.

@HannesWell
Copy link
Member Author

It's indeed more of a workaround.
But with the current state of tycho-pomless usage and the tools we have now the advantage of using ci-friendly versions does not seem to be as helpful as it used to be.
And I also see an advantage in using the same 'pattern' as everywhere else.

@laeubi
Copy link
Member

laeubi commented Nov 23, 2024

But with the current state of tycho-pomless usage and the tools we have now the advantage of using ci-friendly versions does not seem to be as helpful as it used to be.

Just because it is not leveraged do not mean its not useful, e.g. even at the current state only one property needs to be updated (the parent version) and one can perform a release with proper versions in the metadata.

Also without using this feature the regression in Tycho would probably not be discovered.

And I also see an advantage in using the same 'pattern' as everywhere else.

Actually the goal is to use CI-Friendly versions everywhere P2 is just the first project that was converted to act as a demonstration/incubator.

@HannesWell
Copy link
Member Author

Update was now done manually.

@HannesWell HannesWell closed this Nov 25, 2024
@HannesWell HannesWell deleted the revert-ci-friendly-versions branch November 25, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants