Improve lambda breakpoint toggle (#146)

When not selecting the whole lambda expression, the codeSelect fails to find the lambda method element. So instead of using the document selection, we use the breakpoint locator location if that provides more wider range. Signed-off-by: Gayan Perera <[email protected]>
eclipse-jdt · Dec 12, 2024 · 4bb6f3a · 4bb6f3a
1 parent ddf0a0a
commit 4bb6f3a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/...se.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/actions/ToggleBreakpointAdapter.java b/...se.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/actions/ToggleBreakpointAdapter.java
@@ -338,7 +338,8 @@ static IStatus doToggleLambdaMethodBreakpoints(IWorkbenchPart part, ISelection s
 			synchronized (unit) {
 				unit.reconcile(ICompilationUnit.NO_AST, false, null, null);
 			}
-			IJavaElement[] elements = unit.codeSelect(textSelection.getOffset(), textSelection.getLength());
+			IJavaElement[] elements = unit.codeSelect(Math.min(textSelection.getOffset(), loc.getMemberOffset()), Math.max(textSelection.getLength(), loc.getNodeLength()));
+
 			if (elements == null || elements.length == 0) {
 				ValidBreakpointLocationLocator locNew = new ValidBreakpointLocationLocator(loc.getCompilationUnit(), textSelection.getStartLine()
 						+ 1, true, true);