Fix #91: Stack trace detection not working in colored console

[mihnita]

What it does

Removes the ANSI escape sequences before detecting links.

How to test

See eclipse-platform/eclipse.platform#535

The easiest way to reproduce was to create a new project and println the stack trace.

Attached a small file reproducing the problem.
I've tested with ANSI Support enabled and disabled, and I've checked that the links work and jump at the proper line.

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

Main.java.zip

[mihnita]

Clean version of the closed PR eclipse-platform/eclipse.platform.debug#148 (identical code, work done in a feature branch instead of main)

[mihnita]

Note: I don't insist on this PR, and I agree with this approach:

I think we should not apply a quick-fix here as it unnecessary complicates things. The stacktraces are just one example and I think the ANSI console should best "hide" the ANSI nature that is when I copy/paste things, copy without escapes should be default and for API it should return a plain text and all else (HTML, RTF, with escapes) should be special cases one needs to explcitily trigger.

But it looks like I need to tinker (quite aggressively?) with ConsoleDocument, and in general change how things are implemented now.
So I don't think I can do it in time for the next release (2023-03).

I will 100% respect your decision if you think it is best to do this patchy fix, or live with the bug for another release
(or more? I hope not, but one never knows)

Thank you,
M.

[jukzi]

Hi @mihnita, i think that PR is valid. Can you please resolve the conflict and add a junit test? See JavaDebugStackTraceConsoleTest for example.

[mihnita]

Thank you! I'll do it over the weekend. Mihai

…

On Wed, Dec 4, 2024, 04:33 Jörg Kubitz ***@***.***> wrote: Hi @mihnita <https://github.com/mihnita>, i think that PR is valid. Can you please resolve the conflict and add a junit test? See JavaDebugStackTraceConsoleTest for example. — Reply to this email directly, view it on GitHub <#174 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJ7ITRUKWHUS4JULT4ANAT2D3ZCXAVCNFSM6AAAAABTAB7NFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJXGIZDKMBTGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>