Supplying JDK version to disambiguate types to open #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @iloveeclipse @jukzi , could you please check this |
jukzi
reviewed
Jan 27, 2025
...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java
Outdated
Show resolved
Hide resolved
jukzi
reviewed
Jan 27, 2025
...lipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/console/JavaStackTraceHyperlink.java
Outdated
Show resolved
Hide resolved
eclipse-jdt#121 This commit filters specified JDK version on java stack traces to open exact version Fixes : eclipse-jdt#121
SougandhS
force-pushed
the
JDK_version_to_disambiguate_type
branch
from
38aa8fe to
4bbf9a2
Compare
jukzi
approved these changes
Jan 27, 2025
|
Thank you @jukzi |
|
well, thanks to you, @SougandhS, i think this is a really good enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#121
This commit filters specified JDK version on java stack traces to open exact version
Before :
on clicking link
at java.util.StringJoiner.compactElts([email protected]/StringJoiner.java:248)
After :
for at java.util.StringJoiner.compactElts(java.base@23/StringJoiner.java:248)
If no version matches -> all results are shown
eg : at java.util.StringJoiner.compactElts([email protected]/StringJoiner.java:248)
Fixes : #121
What it does
How to test
Author checklist