-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linux riscv64 build with bundles #1445
Add linux riscv64 build with bundles #1445
Conversation
This is another part of fixing #1443. But I am not sure how to verify this until now, please tell me if any issues. It seems the error from CI was the same with other architecture. |
Good news is that this can be built wit |
8d805c4
to
ad3de7a
Compare
ad3de7a
to
e0cea72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the p2.inf changes the rest looks good. We can't get these parts in as they will break building repos by trying to put linux.riscv64 fragments in the repository but they will not be built.
This should be totally irrelevant for builds that aim at riscv64.
local-build/org.eclipse.swt.fragments.localbuild/META-INF/p2.inf
Outdated
Show resolved
Hide resolved
Signed-off-by: Bo YU <[email protected]>
e0cea72
to
37eb397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Thanks for reviewing this. I over-referenced to add support eclipse from other architectures. |
Thanks for approving this.:) Now I am still get the FAILURE on riscv64 hardware, this is log. Could you give me some advice on the next steps which how to push the porting works. TIA. |
This log makes me believe that jna https://github.com/java-native-access/jna lacks freebsd.riscv64 support. If you look in https://repo1.maven.org/maven2/net/java/dev/jna/jna/5.14.0/jna-5.14.0.jar:META-INF/MANIFEST.MF you'll notice there is only com/sun/jna/freebsd-x8 |
Thanks, I will look at this. |
Thanks for the pointer again. The issue has been confirmed from jna upstream also, see the PR. But a harder problem for me now is how can I replace this jna with the modified locally. There is the com.sun.jna with version defined. So can I comment out the line and put the jna updated into /$HOME/.m2/repository. From the original build stack log, can I assume this jar is stored in /$HOME/.m2/repository/p2/osgi/bundle/com.sun.jna/5.14.0.v20231211-1200/ (or other place)? Can this way work? TIA. |
@yuzibo I would go for local mvn install of fixed jna version (preferably with bumped version) and require that version in the target file otherwise you risk maven overriding after/when it sees checksums mismatch (I am not 100% sure here). |
No description provided.