Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent StatusLine from SWT Invalid thread access #2792

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mickaelistria
Copy link
Contributor

Since monitor methods may be invoked from any thread, make sure we wrap all SWT operations in UI Thread.

Fixes eclipse-jdt/eclipse.jdt.core#3718

Since monitor methods may be invoked from any thread, make sure we wrap
all SWT operations in UI Thread.

Fixes eclipse-jdt/eclipse.jdt.core#3718
@mickaelistria
Copy link
Contributor Author

ProgressDialog would also deserve to be fixed together with this change.

Copy link
Contributor

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 30m 4s ⏱️ - 4m 14s
 7 720 tests ±0   7 492 ✅ +1  228 💤 ±0  0 ❌  - 1 
24 321 runs  ±0  23 572 ✅ +1  749 💤 ±0  0 ❌  - 1 

Results for commit a01c7f7. ± Comparison against base commit 35844b5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlainJarExportTests test fails due the monitor use in wrong thread
1 participant