Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use System.lineSeparator() #1697

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

akurtakov
Copy link
Member

System.getProperty("line.separator") involves SecurityManager checks (depending on JVM used), key validity check and Properties retrieval while lineSeparator() returns the value used to populate the properties with directly.

akurtakov and others added 2 commits January 20, 2025 07:55
System.getProperty("line.separator") involves SecurityManager checks
(depending on JVM used), key validity check and Properties retrieval
while lineSeparator() returns the value used to populate the properties
with directly.
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF
team/bundles/org.eclipse.compare/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 3167d9c448460de1a4b443fa68f8d9c12714f803 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 20 Jan 2025 06:03:50 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF
index 7a0a26c0b2..001bf0db3a 100644
--- a/team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF
+++ b/team/bundles/org.eclipse.compare.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.compare.core
-Bundle-Version: 3.8.600.qualifier
+Bundle-Version: 3.8.700.qualifier
 Bundle-Vendor: %providerName
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)"
 Bundle-RequiredExecutionEnvironment: JavaSE-17
diff --git a/team/bundles/org.eclipse.compare/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.compare/META-INF/MANIFEST.MF
index 512ee51723..deda14554b 100644
--- a/team/bundles/org.eclipse.compare/META-INF/MANIFEST.MF
+++ b/team/bundles/org.eclipse.compare/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.compare; singleton:=true
-Bundle-Version: 3.11.200.qualifier
+Bundle-Version: 3.11.300.qualifier
 Bundle-Activator: org.eclipse.compare.internal.CompareUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

Test Results

 1 755 files  ±0   1 755 suites  ±0   1h 27m 36s ⏱️ + 2m 40s
 4 170 tests ±0   4 147 ✅ ±0   23 💤 ±0  0 ❌ ±0 
13 107 runs  ±0  12 940 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 3fa0e76. ± Comparison against base commit 0dfe86c.

@akurtakov akurtakov merged commit 13a7085 into eclipse-platform:master Jan 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants