Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read retained messages #541

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

gathanase
Copy link
Contributor

No description provided.

…t/gateway/southbound/mqtt/impl/MqttClientHandler.java

Co-authored-by: Tim Ward <[email protected]>
Copy link
Contributor

@timothyjward timothyjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. My only comment is in as a suggestion, which is that it's best to make lock objects final so that they can be optimised by the JIT, and also so that people don't accidentally change them.

@timothyjward timothyjward merged commit 68e28b2 into eclipse-sensinact:master Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants