Switch ExclusionsTab to CheckboxTableViewer with accessibility fixes #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors ExclusionsTab to use CheckboxTableViewer with ArrayContentProvider, removing the custom tree provider. Adds AccessibleListener so screen readers announce correct check/uncheck actions and distinguish duplicate entries (e.g., multiple “DTD” items). Improves maintainability and accessibility without changing functionality.
The warning message in the Task Tag preference tab was previously created with a plain Label, which was not being read out by screen readers. This has been refactored to use a Text control in read-only, wrap, and multi-line mode so that assistive technologies can announce the content properly. Additional adjustments: -Applied a GridData with widthHint to make the control slightly wider than its natural size for better readability - Styled the Text with system background and foreground colors to visually match surrounding labels
The “Hover Preferences” heading was previously implemented as a plain Label. Since Label text was not being announced by assistive technologies, it has been replaced with a Text control configured as read-only, wrapped, and multi-line. Changes include: - Replaced Label with Text (SWT.READ_ONLY | SWT.WRAP | SWT.MULTI). - Preserved layout by reusing the same GridData constraints. - Applied system background/foreground colors so the Text visually blends in with surrounding labels.
The encoding description in the JSON Files preference page was previously implemented as a plain Label, which was not announced by screen readers. This has been updated to use a Text control in read-only, wrap, and multi-line mode. Changes include: - Replaced Label with Text so the content can be focused and read by assistive technologies. - Applied GridData with 2-column span to maintain layout. - Styled background/foreground to visually match surrounding labels.
The encoding description in the JSON Files preference page was previously implemented as a plain Label, which was not announced by screen readers. This has been updated to use a Text control in read-only, wrap, and multi-line mode. Changes include: - Replaced Label with Text so the content can be focused and read by assistive technologies. - Applied GridData with 2-column span to maintain layout. - Styled background/foreground to visually match surrounding labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors ExclusionsTab to use CheckboxTableViewer with ArrayContentProvider, removing the custom tree provider. Adds AccessibleListener so screen readers announce correct check/uncheck actions and distinguish duplicate entries (e.g., multiple “DTD” items). Improves maintainability and accessibility without changing functionality.