Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style:added overflow:scroll to textfields #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Pavan-Rajesh
Copy link

added overflow:scroll to the div

jsonschemapull

new One after modifying
jsonnew

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you minimize the PR to the minimum, i.e. only adding the overflow styling instead of doing all the additional formatting changes?

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the proposed change fixes the issue, we now have scroll bars for every demo example which is visually not appealing. We should find an alternative solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants