Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken link in what-is-jsonforms page #305

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AssekoudaSamtou
Copy link

When you hover and click the Getting started link at the end of the documentation homepage (Figure 1), it takes you to 404-page https://jsonforms.io/getting-started (Figure 2).

image
Figure 1

image
Figure 2

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AssekoudaSamtou, thanks for the contribution ❤️

However the issue is not in the link itself. The issue comes from the top nav bar not appending the trailing slash, e.g. when you append the trailing slash yourself in the Browser or click on "What is JSON Forms?" then the link works.

I think we need to adjust these to entries here to specify a trailing slash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants