Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pluto where possible instead of hic calls #270

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Use pluto where possible instead of hic calls #270

merged 2 commits into from
Mar 28, 2025

Conversation

wdeconinck
Copy link
Member

@wdeconinck wdeconinck commented Mar 21, 2025 •
edited
Loading

This PR tends to provide the most minimal changes to start using pluto, introduced with #269

  • Use pluto to allocate and deallocate device memory and host memory
  • Use pluto to transfer data between host and device

No advanced configuration of memory resources is used: host memory is allocated using the pluto::host_resource, which provides 256-byte aligned memory and device memory is allocated using the pluto::device_resource, which maps to hicMalloc internally (using CUDA or HIP).

@wdeconinck wdeconinck force-pushed the feature/add_pluto branch 5 times, most recently from 12436b4 to 0ce247f Compare March 27, 2025 15:03
@github-actions GitHub Actions
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14111788835.

@wdeconinck wdeconinck force-pushed the feature/use_pluto branch 2 times, most recently from c702d3f to d1096da Compare March 27, 2025 18:01
@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14113356241.

@wdeconinck wdeconinck changed the base branch from feature/add_pluto to develop March 27, 2025 18:16
@wdeconinck wdeconinck marked this pull request as ready for review March 27, 2025 18:18
@wdeconinck wdeconinck requested a review from sbrdar March 27, 2025 18:19
@github-actions GitHub Actions
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14115029495.

@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14115568993.

sbrdar
sbrdar approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@sbrdar sbrdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @wdeconinck for this resource manager. The PR is greatly useful and I am looking forward to have it merged in the develop! I just had a few questions and remarks.

@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14132567744.

1 similar comment
@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14132567744.

@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14132826417.

@wdeconinck wdeconinck merged commit f537250 into develop Mar 28, 2025
33 checks passed
@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14133824245.

1 similar comment
@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14133824245.

@github-actions GitHub Actions
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf/private-downstream-ci/actions/runs/14134395202.

@wdeconinck wdeconinck mentioned this pull request Apr 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrdar sbrdar sbrdar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdeconinck @sbrdar