chore: add typecheck and fix type

edmundhung · May 8, 2024 · c841225 · c841225
1 parent 4aab4cb
commit c841225
Show file tree

Hide file tree

Showing 17 changed files with 35 additions and 31 deletions.
diff --git a/packages/conform-dom/form.ts b/packages/conform-dom/form.ts
@@ -623,7 +623,7 @@ function shouldNotify<Schema>(
 	return false;
 }
 
-export function createFormContext<
+export function unstable_createFormContext<
 	Schema extends Record<string, any>,
 	FormError = string[],
 	FormValue = Schema,

diff --git a/packages/conform-dom/index.ts b/packages/conform-dom/index.ts
@@ -11,7 +11,7 @@ export {
 	type FormContext,
 	type SubscriptionSubject,
 	type SubscriptionScope,
-	createFormContext as unstable_createFormContext,
+	unstable_createFormContext,
 } from './form';
 export { type FieldElement, isFieldElement } from './dom';
 export {

diff --git a/packages/conform-dom/package.json b/packages/conform-dom/package.json
@@ -18,12 +18,13 @@
 	},
 	"scripts": {
 		"build:js": "rollup -c",
-		"build:ts": "tsc",
+		"build:ts": "tsc --emitDeclarationOnly",
 		"build": "pnpm run \"/^build:.*/\"",
 		"dev:js": "pnpm run build:js --watch",
 		"dev:ts": "pnpm run build:ts --watch",
 		"dev": "pnpm run \"/^dev:.*/\"",
-		"prepare": "pnpm run build"
+		"prepare": "pnpm run build",
+		"typecheck": "tsc --noEmit"
 	},
 	"repository": {
 		"type": "git",

diff --git a/packages/conform-dom/submission.ts b/packages/conform-dom/submission.ts
@@ -14,7 +14,7 @@ export type SubmissionState = {
 	validated: Record<string, boolean>;
 };
 
-export type SubmissionContext<Value = null, FormError = string[]> = {
+export type SubmissionContext<Value = unknown, FormError = string[]> = {
 	intent: Intent | null;
 	payload: Record<string, unknown>;
 	fields: Set<string>;

diff --git a/packages/conform-dom/tsconfig.json b/packages/conform-dom/tsconfig.json
@@ -8,7 +8,6 @@
 		"noUncheckedIndexedAccess": true,
 		"strict": true,
 		"declaration": true,
-		"emitDeclarationOnly": true,
 		"composite": true,
 		"skipLibCheck": true
 	}

diff --git a/packages/conform-react/context.tsx b/packages/conform-react/context.tsx
@@ -10,7 +10,7 @@ import {
 	type SubscriptionScope,
 	type SubscriptionSubject,
 	type FormOptions as BaseFormOptions,
-	unstable_createFormContext as createBaseFormContext,
+	unstable_createFormContext,
 	formatPaths,
 	getPaths,
 	isPrefix,
@@ -479,7 +479,7 @@ export function createFormContext<
 	options: FormOptions<Schema, FormError, FormValue>,
 ): FormContext<Schema, FormError, FormValue> {
 	let { onSubmit, ...rest } = options;
-	const context = createBaseFormContext(rest);
+	const context = unstable_createFormContext(rest);
 
 	return {
 		...context,

diff --git a/packages/conform-react/index.ts b/packages/conform-react/index.ts
@@ -15,8 +15,8 @@ export {
 } from './context';
 export { useForm, useFormMetadata, useField } from './hooks';
 export {
-	Control as unstable_Control,
-	useControl as unstable_useControl,
+	unstable_Control,
+	unstable_useControl,
 	useInputControl,
 } from './integrations';
 export {

diff --git a/packages/conform-react/integrations.ts b/packages/conform-react/integrations.ts
@@ -294,10 +294,12 @@ export function useInputValue<
 	return [value, setValue] as const;
 }
 
-export function useControl<
+export function unstable_useControl<
 	Value extends string | string[] | Array<string | undefined>,
 >(meta: { key?: Key | null | undefined; initialValue?: Value | undefined }) {
+	// eslint-disable-next-line react-hooks/rules-of-hooks
 	const [value, setValue] = useInputValue(meta);
+	// eslint-disable-next-line react-hooks/rules-of-hooks
 	const { register, change, focus, blur } = useInputEvent();
 	const handleChange = (
 		value: Value extends string ? Value : string | string[],
@@ -377,13 +379,15 @@ export function useInputControl<
 	};
 }
 
-export function Control<
+export function unstable_Control<
 	Value extends string | string[] | Array<string | undefined>,
 >(props: {
 	meta: { key?: Key | null | undefined; initialValue?: Value | undefined };
-	render: (control: ReturnType<typeof useControl<Value>>) => React.ReactNode;
+	render: (
+		control: ReturnType<typeof unstable_useControl<Value>>,
+	) => React.ReactNode;
 }) {
-	const control = useControl(props.meta);
+	const control = unstable_useControl(props.meta);
 
 	return props.render(control);
 }
diff --git a/packages/conform-react/package.json b/packages/conform-react/package.json
@@ -18,12 +18,13 @@
 	},
 	"scripts": {
 		"build:js": "rollup -c",
-		"build:ts": "tsc",
+		"build:ts": "tsc --emitDeclarationOnly",
 		"build": "pnpm run \"/^build:.*/\"",
 		"dev:js": "pnpm run build:js --watch",
 		"dev:ts": "pnpm run build:ts --watch",
 		"dev": "pnpm run \"/^dev:.*/\"",
-		"prepare": "pnpm run build"
+		"prepare": "pnpm run build",
+		"typecheck": "tsc --noEmit"
 	},
 	"repository": {
 		"type": "git",

diff --git a/packages/conform-react/tsconfig.json b/packages/conform-react/tsconfig.json
@@ -9,7 +9,6 @@
 		"noUncheckedIndexedAccess": true,
 		"strict": true,
 		"declaration": true,
-		"emitDeclarationOnly": true,
 		"composite": true,
 		"skipLibCheck": true
 	}

diff --git a/packages/conform-validitystate/package.json b/packages/conform-validitystate/package.json
@@ -18,12 +18,13 @@
 	},
 	"scripts": {
 		"build:js": "rollup -c",
-		"build:ts": "tsc",
+		"build:ts": "tsc --emitDeclarationOnly",
 		"build": "pnpm run \"/^build:.*/\"",
 		"dev:js": "pnpm run build:js --watch",
 		"dev:ts": "pnpm run build:ts --watch",
 		"dev": "pnpm run \"/^dev:.*/\"",
-		"prepare": "pnpm run build"
+		"prepare": "pnpm run build",
+		"typecheck": "tsc --noEmit"
 	},
 	"repository": {
 		"type": "git",

diff --git a/packages/conform-validitystate/tsconfig.json b/packages/conform-validitystate/tsconfig.json
@@ -7,7 +7,6 @@
 		"allowSyntheticDefaultImports": true,
 		"strict": true,
 		"declaration": true,
-		"emitDeclarationOnly": true,
 		"composite": true,
 		"skipLibCheck": true
 	}

diff --git a/packages/conform-yup/package.json b/packages/conform-yup/package.json
@@ -18,12 +18,13 @@
 	},
 	"scripts": {
 		"build:js": "rollup -c",
-		"build:ts": "tsc",
+		"build:ts": "tsc --emitDeclarationOnly",
 		"build": "pnpm run \"/^build:.*/\"",
 		"dev:js": "pnpm run build:js --watch",
 		"dev:ts": "pnpm run build:ts --watch",
 		"dev": "pnpm run \"/^dev:.*/\"",
-		"prepare": "pnpm run build"
+		"prepare": "pnpm run build",
+		"typecheck": "tsc --noEmit"
 	},
 	"repository": {
 		"type": "git",

diff --git a/packages/conform-yup/tsconfig.json b/packages/conform-yup/tsconfig.json
@@ -8,7 +8,6 @@
 		"noUncheckedIndexedAccess": true,
 		"strict": true,
 		"declaration": true,
-		"emitDeclarationOnly": true,
 		"composite": true,
 		"skipLibCheck": true
 	}

diff --git a/packages/conform-zod/package.json b/packages/conform-zod/package.json
@@ -18,12 +18,13 @@
 	},
 	"scripts": {
 		"build:js": "rollup -c",
-		"build:ts": "tsc",
+		"build:ts": "tsc --emitDeclarationOnly",
 		"build": "pnpm run \"/^build:.*/\"",
 		"dev:js": "pnpm run build:js --watch",
 		"dev:ts": "pnpm run build:ts --watch",
 		"dev": "pnpm run \"/^dev:.*/\"",
-		"prepare": "pnpm run build"
+		"prepare": "pnpm run build",
+		"typecheck": "tsc --noEmit"
 	},
 	"repository": {
 		"type": "git",

diff --git a/packages/conform-zod/tsconfig.json b/packages/conform-zod/tsconfig.json
@@ -8,7 +8,6 @@
 		"noUncheckedIndexedAccess": true,
 		"strict": true,
 		"declaration": true,
-		"emitDeclarationOnly": true,
 		"composite": true,
 		"skipLibCheck": true
 	}

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,10 +1,10 @@
 {
 	"references": [
-		{ "path": "packages/conform-dom" },
-		{ "path": "packages/conform-yup" },
-		{ "path": "packages/conform-zod" },
-		{ "path": "packages/conform-react" },
-		{ "path": "packages/conform-validitystate" }
+		{ "path": "./packages/conform-dom" },
+		{ "path": "./packages/conform-yup" },
+		{ "path": "./packages/conform-zod" },
+		{ "path": "./packages/conform-react" },
+		{ "path": "./packages/conform-validitystate" }
 	],
 	"files": []
 }