Add colour to filenames and a blank link to make visually reading easier #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bodymindarts
suggested changes
Nov 7, 2020
| @@ -17,3 +17,4 @@ glob = "0.3.0" | |||
| serde = { version = "1.0", features = ["derive"] } | |||
| serde_yaml = "0.8" | |||
| serde_json = "1.0" | |||
| ansi_term = "0.11.0" # Version 0.11.0 already required for clap | |||
There was a problem hiding this comment.
Rust can handle different versions of the same crate being in the source tree. I'd just use the latest version 0.12. The code where you use it does not interact with anything related to clap so there is no problem.
| @@ -9,6 +9,7 @@ use std::{ | |||
| path::Path, | |||
| rc::Rc, | |||
| }; | |||
| use ansi_term::Colour::Green; | |||
There was a problem hiding this comment.
In rust its common to let rustfmt format the files before checking them in (usually editors handle this automatically). Rustfmt orders use statements alphabetically (meaning this line would be line 1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the code to add a blank line before the filename and colour it green. This makes seeing the blocks easier when reviewing the results.