Fix the missing include_subsume flag so that subsumed tuples does not show up for rules
#474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot show up for rules To see how this bug can cause failures, comment out the lines where `from_column_index` is used (which is hiding the bug) and use `LazyTrie::default` instead and run the test.
CodSpeed Performance ReportMerging #474 will not alter performanceComparing Summary
|
oflatt
approved these changes
Dec 3, 2024
|
I'm not sure. We can bump eggcc's egglog version and see if it's faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see how this bug can cause failures, comment out the lines where
from_column_indexis used (which is hiding the bug) and useLazyTrie::defaultinstead and run the tests again.