Skip to content

run clang-format in CI #1692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 14, 2025
Merged

run clang-format in CI #1692

merged 6 commits into from
Apr 14, 2025

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 30, 2024

Briefly, what does this PR introduce?

This is like eic/epic#705

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Yes, current PR's will have to be rebased, however there is a procedure to do edits fully automated.

Does this PR change default behavior?

No

@github-actions github-actions bot added topic: infrastructure topic: documentation Improvements or additions to documentation topic: calorimetry relates to calorimetry topic: tracking Relates to tracking reconstruction topic: PID Relates to PID reconstruction topic: far-forward Far forward reconstruction topic: far-backward Reconstruction related to far backward detectors topic: barrel topic: forward topic: backward topic: jets topic: digitization labels Dec 30, 2024
@veprbl veprbl force-pushed the pr/clang-format-ci branch 2 times, most recently from 2d55bbd to bc11374 Compare December 30, 2024 03:39
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

Copy link
Contributor

@wdconinc wdconinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't be done in this PR, but we should add the squash commit to the git blame ignore file in a follow up commit since this touches so many files.

And I approve of this change.

@veprbl veprbl force-pushed the pr/clang-format-ci branch 2 times, most recently from e440a3b to 3f7fb58 Compare January 17, 2025 18:45
@veprbl veprbl force-pushed the pr/clang-format-ci branch from 70f6154 to a2dfc11 Compare April 14, 2025 00:24
wdconinc
wdconinc previously approved these changes Apr 14, 2025
@veprbl veprbl enabled auto-merge April 14, 2025 04:18
@veprbl veprbl added this pull request to the merge queue Apr 14, 2025
Merged via the queue into main with commit 0693491 Apr 14, 2025
83 of 86 checks passed
@veprbl veprbl deleted the pr/clang-format-ci branch April 14, 2025 05:51
@veprbl veprbl added the backport v1.24 Backport into v1.24 label Apr 17, 2025
@epic-capybara
Copy link

Backport failed for v1.24, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v1.24
git worktree add -d .worktree/backport-1692-to-v1.24 origin/v1.24
cd .worktree/backport-1692-to-v1.24
git switch --create backport-1692-to-v1.24
git cherry-pick -x 06934917acc0fc01b364b53cd25f23764dc2dfe4

@veprbl veprbl removed the backport v1.24 Backport into v1.24 label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: backward topic: barrel topic: calorimetry relates to calorimetry topic: digitization topic: documentation Improvements or additions to documentation topic: far-backward Reconstruction related to far backward detectors topic: far-forward Far forward reconstruction topic: forward topic: infrastructure topic: jets topic: PID Relates to PID reconstruction topic: tracking Relates to tracking reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants