-
Notifications
You must be signed in to change notification settings - Fork 30
Low-Q2 Charge Sharing #1763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Low-Q2 Charge Sharing #1763
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Capybara summary for PR 1763
|
Need a rebase. |
There are some changes in the BTOF charge sharing I need to understand/fix and discus whether the changes are actually improvements or not. |
What's the problem you're facing, if you don't mind me asking? I think it is a nice improvement over the original LGADChargeSharing. I've always considered testing cellID with position converter and see if it throws error is a bit of a hack. I did not know m_seg.neighbours exist at all. |
It's the differences in the capybara I don't quite understand: I thought that the changes shouldn't make a difference to the number or charge of hits if the charge limit is set to 0. But it looks like there are significantly fewer hits being created. The neighbours will only work if the sensor uses a segmentation in the geometry which may not always be the case (but probably always should be...). I don't believe this will account for the edges of sensors either, so a hit in the detector can probably spread outside the sensor. |
Looks like the problem comes from the MultiSegmentation used for the BTOF. The dd4hep neighbours function doesn't return any cellIDs when it is used. If it is possible to recover which sub-segmentation was used for the specific CellID this might be fixable but I haven't looked yet. |
for more information, see https://pre-commit.ci
…Low-Q2-Charge-Sharing
Briefly, what does this PR introduce?
Introduces sensor charge sharing for hits in the Low-Q2 Tagger dividing a single SimTrackerHit into several.
The method originally introduced for LGADs has been simplified and optimized to make it more accessible for future users, making more use of functions provided by dd4hep.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Adds the TaggerTrackerSharedHits to the output and uses them as the input to the digitization.