Add Lowq2 track association #1775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Need to fix some memory access issues https://github.com/eic/EICrecon/actions/runs/14180103934/job/39724400039?pr=1775#step:8:1153 |
Capybara summary for PR 1775
|
github-actions
bot
added
the
topic: far-backward
veprbl
force-pushed
the
Fix-lowq2-track-association
branch
from
8d615ab to
fe949e1
Compare
github-actions
bot
added
topic: calorimetry
veprbl
force-pushed
the
Fix-lowq2-track-association
branch
from
fe949e1 to
6c90821
Compare
veprbl
removed
topic: calorimetry
veprbl
reviewed
Apr 15, 2025
| @@ -17,18 +17,16 @@ | |||
| namespace eicrecon { | |||
|
|
|||
| using FarDetectorLinearProjectionAlgorithm = | |||
| algorithms::Algorithm<algorithms::Input<edm4eic::TrackSegmentCollection>, | |||
| algorithms::Algorithm<algorithms::Input<edm4eic::TrackCollection>, | |||
| algorithms::Output<edm4eic::TrackParametersCollection>>; | |||
There was a problem hiding this comment.
(Just a thought)
For Acts tracking, we actually output projections as TrackSegments.
src/factories/fardetectors/FarDetectorLinearProjection_factory.h
Outdated
Show resolved
Hide resolved
Co-authored-by: Dmitry Kalinkin <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Reorganization of the FarDetectorLinearTracking to allow Track-Particle associations to be produced for the Low-Q2 Tagger.
Not quite the whole picture but this PR should stand alone before the associations are propagated to the Post-ML tracks and injected into the common tracking flow.
There are lots of alternative approaches to this, the current one here felt like the least ugly (assuming it works).
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
Changes the output of FarDetectorLinearTracking to an edm4eic::Track rather than edm4eic::TrackSegment. At a later date both might be produced as the TrackSegment contains TrackPoints which are equivalent to a missing 3D measurement.