MatrixTransferStatic: move matrix configurations to config, implement OMD config for 130 GeV #1780
Conversation
… OMD config for 130 GeV
Capybara summary for PR 1780
|
veprbl
force-pushed
the
pr/omd_config
branch
2 times, most recently
from
4938c7e to
dfbe0f0
Compare
|
I ran my same set of jobs that I used to verify the other PR to test this one. The resulting plots were empty when I ran my plot maker. Upon further inspection of the EICrecon output, the ForwardOffMRecParticles branch is completely empty. The output from npsim shows the hits, as expected, so the simulation portion is fine.
|
|
Looking at the logs, the issue is that you removed the ability for the code to process a neutron beam, which was explicitly accounted for in the other PR - it expects all beams here to be protons.
|
|
Added commit to fix issue. Jobs are running now to test. |
for more information, see https://pre-commit.ci
|
Some reconstructed output from previous tests with other PR: Reconstructed output with this PR (now):
There is still a major problem with the final number of reconstructed tracks. At very low-t, the acceptance should be close to 100%, but when I look at a 150k event sample, I only get about 7k total reconstructed protons - I should be getting around 113k. I have looked at several npsim output files, and the number of detector hits I am getting is consistent with expectations for these events, so it's something else with with this reconstruction approach. |
|
In the other PR the values that look like cuts were updated: |
|
Yes, the PR I made had updated values for everything, including the matrices for the OMD. |
|
Running the jobs again to check. |
|
That fixed it:
|
|
@ajentsch I assume, this is okay to backport to 25.04.1? |
|
Yup.
…On Wed, Apr 16, 2025 at 12:15 PM Dmitry Kalinkin ***@***.***> wrote:
@ajentsch <https://github.com/ajentsch> I assume, this is okay to
backport to 25.04.1?
—
Reply to this email directly, view it on GitHub
<#1780 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADABSF6H2JVDTAZB4GUMHDT2ZZ6ZVAVCNFSM6AAAAAB2IOMN7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJQGA3TKMBSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*veprbl* left a comment (eic/EICrecon#1780)
<#1780 (comment)>
@ajentsch <https://github.com/ajentsch> I assume, this is okay to
backport to 25.04.1?
—
Reply to this email directly, view it on GitHub
<#1780 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADABSF6H2JVDTAZB4GUMHDT2ZZ6ZVAVCNFSM6AAAAAB2IOMN7WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJQGA3TKMBSGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
-------------------------------------------------------------
Alex Jentsch
Assistant Staff Scientist, EIC Directorate
Brookhaven National Laboratory
Upton, NY 11973
Bldg. 510, 2-197
Phone (office): 631-344-2139
Phone (cell): 281-726-0114
Pronouns: he/him/his
|
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin v1.24
git worktree add -d .worktree/backport-1780-to-v1.24 origin/v1.24
cd .worktree/backport-1780-to-v1.24
git switch --create backport-1780-to-v1.24
git cherry-pick -x f8f8dbf9481d112e98169e026f270d1a1674cdc3 |
…config, implement OMD config for 130 GeV (#1809) Backport of #1780. --------- Co-authored-by: Alexander Jentsch <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Briefly, what does this PR introduce?
This provides an alternative implementation for #1769, without duplicating the code
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No
Does this PR change default behavior?
No