Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump downloaded go to version 1.23.4 #621

Merged
merged 1 commit into from
Jan 8, 2025
Merged

feat: bump downloaded go to version 1.23.4 #621

merged 1 commit into from
Jan 8, 2025

Conversation

thall
Copy link
Member

@thall thall commented Jan 8, 2025

If Sage is invoked in an environment where Go is not available in $PATH, Sage will download it.

This should not affect any users that has Go installed outside of an Sage repo.

@thall thall requested a review from a team as a code owner January 8, 2025 12:28
Copy link
Member

@radhus radhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense since it's only affecting the downloaded version! Need to regenerate Makefile in Sage repos though (i.e. in this PR as well?).

If Sage is invoked in an environment where Go is not available in `$PATH`,
Sage will download it.

This should not affect any users that has Go installed outside of an
Sage repo.
@thall thall merged commit 7e3827f into master Jan 8, 2025
3 checks passed
@thall thall deleted the go123 branch January 8, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants