Change echo to printf for portability. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MIGHT address bugs #5 and #8 about that "-e" flag getting printed. echo has portability issues so it's better to use printf (for instance see http://bit.ly/18IxWBY). The only difference is printf won't print a terminal newline, which shouldn't make any difference the way it's being used here.
Unfortunately all my machines either support -e, or echo implicitly supports backslash escapes, so I'm not able to replicate the original issue. However, I'm using the printf version and it hasn't changed the output at all, so there's that.