-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for local datasets. #3
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. Are there any datasets to play with this?
Thanks for your review, @hidmic ! Ready for second pass. Added a dataset in |
@Santoi this hangs the GitHub UI for PR reviews. Does the dataset need to live here? Can we put it elsewhere and instruct the user to request access? On an unrelated note, I see references to Frodo in the repository. This is a public repository. Results are not particularly sensitive but I'd suggest removing company terminology. |
@hidmic Sure. Does it make sense to add a README in the |
@Santoi a README.md under |
@@ -0,0 +1,71 @@ | |||
# 3D Mapping Workflow (Frodo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Santoi nit:
# 3D Mapping Workflow (Frodo) | |
# 3D Mapping Workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it helps, use an LLM to adjust the writing (punctuation, tenses, overall cohesion).
|
||
# Recording devices | ||
|
||
List of the recording devices used during the Frodo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Santoi nit:
List of the recording devices used during the Frodo | |
Some of the recording devices used include: |
|
||
## NeRF Capture | ||
|
||
* Only available for IOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, link to app store would be nice.
|
||
List of the recording devices used during the Frodo | ||
|
||
* iPhone Pro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Santoi nit: links to product briefs would be nice.
|
||
### Online mode | ||
|
||
Requires the host to be connected into the recording device, so as to process the input while it is being captured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Santoi nit:
Requires the host to be connected into the recording device, so as to process the input while it is being captured. | |
Requires the host to be connected to the recording device, so as to process the input while it is being captured. |
### Offline mode | ||
|
||
Saves a directory with the RBG captured frames and the depth frames \+ a transform.json file to feed into the processing tool. | ||
Offline mode is currently bugged. There is an issue with the recording processing, which is not converting the depth buffer correctly into 16 bit numbers. See [this author comment](https://github.com/jc211/NeRFCapture/issues/10#issuecomment-1888164311) for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Santoi nit:
Offline mode is currently bugged. There is an issue with the recording processing, which is not converting the depth buffer correctly into 16 bit numbers. See [this author comment](https://github.com/jc211/NeRFCapture/issues/10#issuecomment-1888164311) for more details. | |
Offline mode is currently bugged. There is an issue with the recording process, which is not converting the depth buffer correctly into 16 bit numbers. See [this author comment](https://github.com/jc211/NeRFCapture/issues/10#issuecomment-1888164311) for more details. |
## Instant NGP | ||
|
||
\[TODO\] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Santoi nit: remove?
Motivation
This PR provides the means to run SplaTAM on previously recorded datasets with the Spectacular AI tool using an iPhone Pro 14 or higher (basically, with a depth sensor).
Description
Original SplaTAM scripts have been adapted so the config files don't have to be manually edited.
The bash script entry point now takes the usual config file, and additionally the path to the dataset previously recorded with SpectacularAI.
Change log
nerfcapture.bash
Changes support SpectacularAI input and output the dataset already processed with SplaTAM.
nerfcapture2dataset.py
Changes make it possible to load a local NeRFCapture dataset and make it compatible with the SplaTAM expected input.
final_recon.py
&splatam.py
Override config file parameters with the command line arguments.
RESULTS.md
Explored technologies and obtained results overview.
README.md
Run instructions for other Ekumembers.