Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fix Launch error on Kodi 17 #36

Open
wants to merge 1 commit into
base: advanced_notifications
Choose a base branch
from
Open

Update Fix Launch error on Kodi 17 #36

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2017

Error caused by No string or buffer found on line 367 fixed.

except ValueError:
changed to
except:

Error caused by No string or buffer found on line 367 fixed.

except ValueError:
changed to
except:
@elParaguayo
Copy link
Owner

elParaguayo commented Feb 25, 2017

Which version of the code are you running? I'm not getting any errors.

Did you download from the "Releases" page?

@ghost
Copy link
Author

ghost commented Feb 25, 2017

Hello, thanks for the reply.

Please bare with me as I have never ever used GitHub to submit a pull before.

It looks like I have submitted it to the wrong place?

Anyway, I have just installed:

addon id="service.bbclivefootballscores" name="BBC Football Scores" version="0.4.5" provider-name="elParaguayo">

On a fresh Kodi 17.1 RC1 Install.

Immediately the error log flags and reports the following:

                                         - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                        Error Type: <type 'exceptions.TypeError'>
                                        Error Contents: expected string or buffer
                                        Traceback (most recent call last):
                                          File "C:\Users\ECHO\AppData\Roaming\Kodi\addons\service.bbclivefootballscores\default.py", line 493, in <module>
                                            scores_service = FootballScoresService()
                                          File "C:\Users\ECHO\AppData\Roaming\Kodi\addons\service.bbclivefootballscores\default.py", line 154, in __init__
                                            self.checkTickers()
                                          File "C:\Users\ECHO\AppData\Roaming\Kodi\addons\service.bbclivefootballscores\default.py", line 367, in checkTickers
                                            tickers = json.loads(self.config.currenttickers)
                                          File "C:\Program Files (x86)\Kodi-17\system\python\Lib\json\__init__.py", line 339, in loads
                                            return _default_decoder.decode(s)
                                          File "C:\Program Files (x86)\Kodi-17\system\python\Lib\json\decoder.py", line 364, in decode
                                            obj, end = self.raw_decode(s, idx=_w(s, 0).end())
                                        TypeError: expected string or buffer
                                        -->End of Python script error report<--

By changing Except: ValueError to Except: the addon does not error and the Notifications work flawlessly.

Once again, please accept my apologies for not knowing my way around GitHub, I am only trying to help :-)

@elParaguayo
Copy link
Owner

Don't apologise. I'm delighted you want to help!

Can you just confirm what version number is showing in the addon.xml file.

@ghost
Copy link
Author

ghost commented Feb 26, 2017

Thank you :-)

It's 0.4.5 in addon.xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant