add vcpkg to readme #1108
add vcpkg to readme #1108
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 30 30
Lines 5908 5908
=======================================
Hits 5404 5404
Misses 504 504 ☔ View full report in Codecov by Sentry. |
|
I think maybe we should add it to the bindings and packages section? |
|
Updated. Let me know if the new commmit suits. |
|
LGTM, what do you think @elalish ? |
README.md
Outdated
|
|
||
| | Language | Packager | Name | Maintenance | | ||
| | --- | --- | --- | --- | | ||
| | C | N/A | N/A | internal | | ||
| | C++ | vcpkg | [manifold](https://github.com/microsoft/vcpkg/tree/master/ports/manifold) | internal | |
There was a problem hiding this comment.
This says vcpkg is under internal maintenance - are we maintaining this package or are you? If it's really going to be internal, we could use a hand setting up a Github Action to publish it.
There was a problem hiding this comment.
I don't think it can be internal, we need to get vcpkg repo to approve the PR.
There was a problem hiding this comment.
Updated to external. Misunderstood it to mean bindings written by others. Thanks!
Fixes #853