Log deserialization errors in MockApmServer

elastic · Dec 5, 2024 · 33bf3c5 · 33bf3c5
1 parent 51fbbea
commit 33bf3c5
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/test/Elastic.Apm.Tests.MockApmServer/Controllers/IntakeV2EventsController.cs b/test/Elastic.Apm.Tests.MockApmServer/Controllers/IntakeV2EventsController.cs
@@ -107,8 +107,18 @@ private async Task<int> ParsePayload()
 		private async Task ParsePayloadLineAndAddToReceivedData(string line)
 		{
 			var foundDto = false;
-			var payload = JsonSerializer
-				.Deserialize<PayloadLineDto>(line, JsonSerializerOptions) ?? throw new ArgumentException("Deserialization failed");
+
+			PayloadLineDto payload;
+			try
+			{
+				payload = JsonSerializer.Deserialize<PayloadLineDto>(line, JsonSerializerOptions)
+					?? throw new ArgumentException("Deserialization failed");
+			}
+			catch (JsonException ex)
+			{
+				_logger?.Error()?.LogException(ex, "Failed to deserialize '{Line}'", line);
+				throw;
+			}
 
 			await HandleParsed(nameof(payload.Error), payload.Error, _mockApmServer.ReceivedData.Errors, _mockApmServer.AddError);
 			await HandleParsed(nameof(payload.Metadata), payload.Metadata, _mockApmServer.ReceivedData.Metadata, _mockApmServer.AddMetadata);