Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure baggage gets copied with baggage prefix #2220

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

Mpdreamz
Copy link
Member

This brings our agent in line with the wider agent specification on how
to implement baggage propagation

https://github.com/elastic/apm/blob/main/specs/agents/tracing-distributed-tracing.md#baggage-related-configuration

This brings our agent in line with the wider agent specification on how
to implement baggage propagation

https://github.com/elastic/apm/blob/main/specs/agents/tracing-distributed-tracing.md#baggage-related-configuration
gregkalapos
gregkalapos previously approved these changes Nov 15, 2023
Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm.

We have some tests covering this (e.g. Elastic.Apm.AspNetCore.Tests.BaggageAspNetCoreTests.AccessBaggageFromUpstream and some others), those need to be updated as well.

@Mpdreamz
Copy link
Member Author

@gregkalapos mind giving this another review to unblock?

@gregkalapos gregkalapos self-requested a review November 16, 2023 14:27
@Mpdreamz Mpdreamz merged commit 29490f2 into main Nov 16, 2023
11 checks passed
@Mpdreamz Mpdreamz deleted the fix/baggage-prefix-on-labels branch November 16, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants