Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable IIS tests #2237

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Reenable IIS tests #2237

merged 9 commits into from
Feb 5, 2024

Conversation

Mpdreamz
Copy link
Member

These were disabled because they started failing on CI possibly due to space constraints.

Re-enabling this again in a PR so that we don't forget this is not running

These were disabled because they started failing on CI possibly due to space constraints.

Re-enabling this again in a PR so that we don't forget this is not running
@Mpdreamz Mpdreamz marked this pull request as ready for review February 5, 2024 15:21
@Mpdreamz
Copy link
Member Author

Mpdreamz commented Feb 5, 2024

Note to reviewer there is still an aggressive filter on limiting the number of IIS tests we run:
https://github.com/elastic/apm-agent-dotnet/pull/2237/files#diff-ea9245e3163f997188985c14c2429e63aece2867185d0668e3d8406291a2febbR102

Will address this in a follow up PR.

Copy link
Contributor

@gregkalapos gregkalapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just 1 small question.

@Mpdreamz Mpdreamz requested a review from gregkalapos February 5, 2024 15:59
@Mpdreamz Mpdreamz merged commit 3f57699 into main Feb 5, 2024
14 checks passed
@Mpdreamz Mpdreamz deleted the feature/reenable-iis-tests branch February 5, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants