-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit memory usage when capturing SOAP request bodies #2274
Limit memory usage when capturing SOAP request bodies #2274
Conversation
Limit memory usage by creating an ArrayPool with limited MaxArrayLength and skipping capturing SOAP bodies larger than that.
src/integrations/Elastic.Apm.AspNetFullFramework/Extensions/SoapRequest.cs
Show resolved
Hide resolved
src/integrations/Elastic.Apm.AspNetFullFramework/Extensions/SoapRequest.cs
Show resolved
Hide resolved
I see testcontainer setup issues, seems unrelated:
|
src/integrations/Elastic.Apm.AspNetFullFramework/Extensions/SoapRequest.cs
Outdated
Show resolved
Hide resolved
Yeah this is due to forks not having access to secrets, rightfully so. #2273 addresses this. #2275 is the continuation of that to ignore certain tests if run on from a pr from a fork that needs TestContainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review feedback - always capture body up to `MaxRequestBodySizeInBytesToCapture`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Limit memory usage by creating an ArrayPool with limited MaxArrayLength and skipping capturing SOAP bodies larger than that.