feat: add typing on some public api functions #1987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
github-actions
bot
added
agent-python
community
|
Thanks for the PR. We should probably add some mypy run in CI to check we are not messing up anything. |
pbabics
force-pushed
the
feat/typing
branch
3 times, most recently
from
cb9d158 to
c5f4cfc
Compare
|
Hello, I've checked mypy output and there is a lot of errors because most of the code either does not have typing or has wrong/incomplete typing |
Right, maybe we can think of an incremental strategy for typing. Let me think about it a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
__init__.py