Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pageLoadParentId configuration #1521

Merged
merged 7 commits into from
Jan 3, 2025
Merged

feat: add pageLoadParentId configuration #1521

merged 7 commits into from
Jan 3, 2025

Conversation

dgieselaar
Copy link
Member

Reviving #1187:

Context

One of the requirements for Crosslinking Synthetics with APM issue was to allow the RUM agent the creation of the page-load transaction as child of the one created in Synthetics.

The main goal of that is to provide visibility into how the synthetic journeys are executed and what actions are happening inside every step. This image extracted from the issue linked above it's a great example.

Summary

We expose a new agent configuration option named pageLoadParentId whose value will be the id of the transaction that we want to establish as parent of the page-load transaction. Before this PR page-load transaction was always treated as the root transaction, now it will be possible to set a parent if needed thanks to this new config.

@dgieselaar dgieselaar mentioned this pull request Aug 3, 2024
Open
vigneshshanmugam
vigneshshanmugam reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/rum-core/src/performance-monitoring/transaction-service.js Outdated Show resolved Hide resolved
vigneshshanmugam
vigneshshanmugam reviewed Jan 2, 2025
View reviewed changes
packages/rum-core/src/performance-monitoring/navigation/capture-navigation.js Outdated

/**
* Set the parent id of the transaction to the page load parent ID.
* This means that the backend transcaction will be the parent of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This means that the backend transcaction will be the parent of
* This means that the backend transaction will be the parent of

packages/rum-core/src/performance-monitoring/transaction-service.js Outdated Show resolved Hide resolved
vigneshshanmugam
vigneshshanmugam previously approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a pending comment https://github.com/elastic/apm-agent-rum-js/pull/1521/files#r1901184242

Thanks @dgieselaar

@dgieselaar dgieselaar force-pushed the page-load-as-child-transaction branch from b45d0a6 to 58c466b Compare January 3, 2025 07:59
@vigneshshanmugam vigneshshanmugam merged commit 25143ab into elastic:main Jan 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgieselaar @vigneshshanmugam @devcorpio