Skip to content

Commit

Permalink
benchmarking: moxy use default tags only (#15078) (#15107)
Browse files Browse the repository at this point in the history
(cherry picked from commit 918ad46)

Co-authored-by: Kostiantyn Masliuk <[email protected]>
  • Loading branch information
mergify[bot] and 1pkg authored Jan 2, 2025
1 parent 717ddab commit 18d3d0f
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 20 deletions.
2 changes: 0 additions & 2 deletions testing/benchmark/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ module "moxy" {

aws_provisioner_key_name = var.private_key

tags = merge(local.ci_tags, module.tags.tags)
depends_on = [module.vpc]
}

Expand All @@ -167,6 +166,5 @@ module "standalone_apm_server" {
elasticsearch_username = "elastic"
elasticsearch_password = module.moxy[0].moxy_password

tags = merge(local.ci_tags, module.tags.tags)
depends_on = [module.moxy]
}
3 changes: 0 additions & 3 deletions testing/infra/terraform/modules/moxy/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,10 @@ resource "aws_instance" "moxy" {
"sleep 1"
]
}

tags = var.tags
}

resource "aws_key_pair" "provisioner_key" {
public_key = file("${var.aws_provisioner_key_name}.pub")
tags = var.tags
}

resource "random_password" "moxy_password" {
Expand Down
6 changes: 0 additions & 6 deletions testing/infra/terraform/modules/moxy/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,3 @@ variable "moxy_bin_path" {
type = string
description = "Moxy path to binary to copy to the worker machine"
}

variable "tags" {
type = map(string)
default = {}
description = "Optional set of tags to use for all resources"
}
3 changes: 0 additions & 3 deletions testing/infra/terraform/modules/standalone_apm_server/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,6 @@ resource "aws_instance" "apm" {
]
)
}

tags = var.tags
}

resource "null_resource" "apm_server_log" {
Expand Down Expand Up @@ -247,7 +245,6 @@ data "external" "latest_apm_server" {

resource "aws_key_pair" "provisioner_key" {
public_key = file("${var.aws_provisioner_key_name}.pub")
tags = var.tags
}

resource "random_password" "apm_secret_token" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,3 @@ variable "apm_server_bin_path" {
type = string
description = "Optionally use the apm-server binary from the specified path instead"
}

variable "tags" {
type = map(string)
default = {}
description = "Optional set of tags to use for all deployments"
}

0 comments on commit 18d3d0f

Please sign in to comment.