-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win: install APM Server in Program Files directory #14905
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
|
|
Installing in Program Data can be a source of privilege escalation because the directory is writable by all users.
2d516a9
to
df1fc80
Compare
@@ -11,7 +11,7 @@ $workdir = Split-Path $MyInvocation.MyCommand.Path | |||
# Create the new service. | |||
New-Service -name apm-server ` | |||
-displayName {{.BeatName | title}} ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: we should probably update the display name
Added backport-8.16 and backport-8.17 labels. Lmk if that's not right |
Motivation/summary
Update the installer script to use PROGRAMFILES placeholder.
Checklist
For functional changes, consider:
How to test these changes
C:\Program Files