Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win: install APM Server in Program Files directory #14905

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inge4pres
Copy link
Contributor

@inge4pres inge4pres commented Dec 11, 2024

Motivation/summary

Update the installer script to use PROGRAMFILES placeholder.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  • deploy APM Server installation on a Windows host
  • verify the installation directory is C:\Program Files

Copy link
Contributor

mergify bot commented Dec 11, 2024

This pull request does not have a backport label. Could you fix it @inge4pres? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.

Copy link
Contributor

mergify bot commented Dec 11, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 11, 2024
@inge4pres inge4pres marked this pull request as ready for review December 31, 2024 14:52
@inge4pres inge4pres requested a review from a team as a code owner December 31, 2024 14:52
Installing in Program Data can be a source of privilege escalation because the directory is writable by all users.
@@ -11,7 +11,7 @@ $workdir = Split-Path $MyInvocation.MyCommand.Path
# Create the new service.
New-Service -name apm-server `
-displayName {{.BeatName | title}} `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: we should probably update the display name

@inge4pres
Copy link
Contributor Author

Just tested this out in a fresh Windows Server VM 2022 (latest pack).
It works as intended after changing the config file, there is a small problem in the Service name which I'll create a card for.

image

image

@carsonip carsonip added backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Jan 2, 2025
@carsonip
Copy link
Member

carsonip commented Jan 2, 2025

Added backport-8.16 and backport-8.17 labels. Lmk if that's not right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants