-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(dra): support qualifier for the main branch #15217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
added
automation
Team:Automation
Label for the Observability productivity team
backport-8.x
Automated backport to the 8.x branch with mergify
labels
Jan 13, 2025
requires further changes in the go build command
v1v
commented
Jan 15, 2025
kruskall
requested changes
Jan 16, 2025
kruskall
approved these changes
Jan 16, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
(cherry picked from commit a6cf66b)
2 tasks
mergify bot
added a commit
that referenced
this pull request
Jan 17, 2025
(cherry picked from commit a6cf66b) Co-authored-by: Victor Martinez <[email protected]>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
backport-8.x
Automated backport to the 8.x branch with mergify
Team:Automation
Label for the Observability productivity team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Implementation details
ELASTIC_QUALIFIER
environment variable should be set when building/packaging the APM Server or using the BK DRA job if aqualifier
needs to be used.LDFLAGS
to honour theELASTIC_QUALIFIER
value.version.Version
references withversion.VersionWithQualifier()
.Checklist
For functional changes, consider:
How to test these changes
After merging it. However, a dry-run will happen in a feature branch but using the
list
commands instead ofcollect
.And also without
ELASTIC_QUALIFIER=alpha1
For instance, I removed the docker generations and test package-snapshot:
DRA
With a qualifier sets to alpha1, see this build
Without a qualifier, see this build
Related issues