-
Notifications
You must be signed in to change notification settings - Fork 587
[enhancement] In esql validation, allow any order of metadata #4579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[enhancement] In esql validation, allow any order of metadata #4579
Conversation
🙂 |
I used flake to get correct line length and updated code. @Mikaayenson Anything else that needs to be done, or can this be merged? :) |
@Mikaayenson @eric-forte-elastic Just small ping, if this can be merged too :) |
@Mikaayenson @eric-forte-elastic Anything which is blocking here? :) |
2336008
to
80780c4
Compare
80780c4
to
887efd9
Compare
@Mikaayenson @eric-forte-elastic I rebased the branch, cleaned up the commit history. Would highly appreciate it if you can merge this PR and bump version if needed etc. It is just a tiny adjustment to not throw errors when a rule contains a permutation of keywords or newlines, that's all :) |
Pull Request
Issue link(s): #4575
Summary - What I changed
Very simple fix to allow any order of esql metadata by adjusting the regex in the validation check.
When using the metadata in the order referenced in the documentation we get a validation error for ESQL with an error message which makes it difficult to find the problem.
Better is to simply allow this official order of metadata :)
How To Test
Checklist
bug
,enhancement
,schema
,maintenance
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist