Add explicit continue-on-error input to the preview workflow (#393)

elastic · Feb 2, 2025 · 162aa07 · 162aa07
1 parent 3748abb
commit 162aa07
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml
@@ -4,8 +4,14 @@ on:
   workflow_call:
     inputs:
       strict:
+        description: 'Treat warnings as errors'
         type: boolean
         default: true
+      continue-on-error:
+        description: 'Do not fail to publish if build fails'
+        type: boolean
+        required: false
+        default: true  # default for will be false after migration
 
 permissions:
   id-token: write
@@ -62,7 +68,7 @@ jobs:
       - name: Build documentation
         if: github.repository != 'elastic/docs-builder'
         uses: elastic/docs-builder@main
-        continue-on-error: ${{ inputs.strict != 'true' }} # Will be removed after the migration phase
+        continue-on-error: ${{ inputs.continue-on-error == 'true' }} # Will be removed after the migration phase
         with:
           prefix: "/${{ github.repository }}/pull/${{ github.event.pull_request.number }}"
           strict: ${{ inputs.strict }}

diff --git a/actions/publish/action.yml b/actions/publish/action.yml
@@ -15,7 +15,7 @@ inputs:
     description: 'Treat warnings as errors'
     required: false
   continue-on-error:
-    description: 'Treat warnings as errors'
+    description: 'Do not fail to publish if build fails'
     required: false
     default: "false"
   private: