Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up parceljs #389

Merged
merged 7 commits into from
Feb 1, 2025
Merged

Set up parceljs #389

merged 7 commits into from
Feb 1, 2025
+3,365 −20

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jan 31, 2025 •
edited
Loading

Context

Prepare redesign.

Changes

Set up parceljs.

  • Move css files into src/Elastic.Markdown/Assets/legacy and import it in styles.css

Notes

  • I was unable to move JS because it heavily relies on global variables, which is hard to achieve with JS modules.
  • The new main.js file is empty and does nothing for now.

Follow-up

  • Set up tailwind

@reakaleek reakaleek force-pushed the feature/setup-parcel branch from ad72e01 to e73c57d Compare January 31, 2025 13:18
@reakaleek reakaleek requested a review from a team January 31, 2025 13:21
@reakaleek reakaleek self-assigned this Jan 31, 2025
@reakaleek reakaleek marked this pull request as ready for review January 31, 2025 13:22
@reakaleek
Copy link
Member Author

Dang, it doesn't work as expected on the deployment

Mpdreamz
Mpdreamz approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work getting it all integrated!

@Mpdreamz @reakaleek
Add ./build.sh watch to integrate all continuous builds. (#390)
131a5bf 
All continuous builds are now servicable through `dotnet watch`

> dotnet watch --project src/docs-builder --no-hot-reload -- serve

Will build web assets without recompiling c# or rebooting the server.

C# or cshtml changes will rebuild automatically.

Markdown files will continue to be server through liverload without a full restart.

Co-authored-by: Jan Calanog <[email protected]>
@reakaleek reakaleek enabled auto-merge (squash) February 1, 2025 09:03
@reakaleek reakaleek merged commit 3748abb into main Feb 1, 2025
5 checks passed
@reakaleek reakaleek deleted the feature/setup-parcel branch February 1, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

Assignees

@reakaleek reakaleek

Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reakaleek @Mpdreamz