-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add otel components command #6539
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
|
|
5c51c6d
to
a8d4dfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a simple integration test to verify that this actually works?
Also, could we use upstream's implementantion here instead of copying it?
I didn't find an obvious way to use it directly from I see our
Shall we test against the real EDOT's output? This would mean that every time we include a new component we will need to update that test too. |
Allright, let's leave it as is then.
I was just thinking about checking if the output looks reasonable, without enumerating the components, but maybe that's a good idea? I'm not sure if we have an integration test that verifies which components are present right now. |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Another thing I see that is missing here is the
Is this something that we should fix or we can just skip it from the output for now? Any thoughts? |
I'd skip it for now and open an issue to include it. We should be as close to builder output as possible. |
Signed-off-by: ChrsMark <[email protected]>
Signed-off-by: ChrsMark <[email protected]>
4f35b9c
to
b617415
Compare
All right, I have removed the Feel free to take a look when you get the time. |
Quality Gate failedFailed conditions |
What does this PR do?
This PR adds the
components
command forotel
mode as described at https://github.com/elastic/opentelemetry-dev/issues/396.Implementation is replicated from https://github.com/open-telemetry/opentelemetry-collector/blob/main/otelcol/command_components.go.
Why is it important?
otel components
command can be used to list the supported components the EDOT includes.Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Build Elastic Agent and execute the command:
Related issues
Questions to ask yourself