Skip to content

Add variant for Kibana >= 8.7.0 with experimental toggles enabled #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Feb 1, 2023

Supersedes #1108.

It adds a new variant for versions of the stack between 8.2 and 8.6, and enables the experimental toggles for Kibana starting on 8.7.

With elastic-package stack up --version 8.7.0-SNAPSHOT:

Captura desde 2023-02-01 12-48-30

It adds technical debt but we don't have another way to do it till we templatize these files, as is attempted in #1055.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-01T13:09:34.777+0000

  • Duration: 33 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 882
Skipped 0
Total 882

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (35/35) 💚
Files 65.909% (87/132) 👍
Classes 61.376% (116/189) 👍
Methods 48.772% (397/814) 👍 0.19
Lines 31.773% (3576/11255) 👍 0.128
Conditionals 100.0% (0/0) 💚

Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsoriano jsoriano merged commit 0440db5 into elastic:main Feb 1, 2023
@jsoriano jsoriano deleted the enable-experimental-toggles-8.7 branch February 1, 2023 13:44
jsoriano added a commit to jsoriano/elastic-package that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants