Updates chatbot-rag-app and simplifies instructions #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates chatbot-rag-app to the latest libraries and simplifies instructions by delegating details of configuration to the .env file. This also works around problems we found in DEBUG mode, by using production mode regardless of task. Doing so notably will allow tracing to work in the future. Efforts here were thanks to many, despite me raising it, notably @joemcelroy @ezimuel @xrmx and @anuraaga Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
anuraaga
reviewed
Dec 19, 2024
Signed-off-by: Adrian Cole <[email protected]>
|
Changes look great overall - one small request please: Could we focus on connecting to Elasticsearch in three scenarios:
Drop connecting with cloud id, we have been moving away from this for a while and unnecessary complicates the connection logic. Im also happy to make this change if you dont have the time. |
Signed-off-by: Adrian Cole <[email protected]>
joemcelroy
approved these changes
Dec 19, 2024
Signed-off-by: Adrian Cole <[email protected]>
anuraaga
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates chatbot-rag-app to the latest libraries and simplifies instructions by delegating details of configuration to the .env file.
This also works around problems we found in DEBUG mode, by using production mode regardless of task. Doing so notably will allow tracing to work in the future.
Efforts here were thanks to many, despite me raising it, notably @joemcelroy @ezimuel @xrmx and @anuraaga