Fix potential ArgumentException with ConditionalWeakTable #8444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetrou
force-pushed
the
ConditionalWeakTable
branch
from
f13f180 to
8f8859c
Compare
|
Hi @gpetrou , thanks a lot for the PR. LGTM! This will be included in the next release. |
flobernd
added
8.x
gpetrou
force-pushed
the
ConditionalWeakTable
branch
from
8f8859c to
3df09b1
Compare
gpetrou
force-pushed
the
ConditionalWeakTable
branch
from
3df09b1 to
f88ffcf
Compare
|
@flobernd I ended up using a newer API for .NET 8. |
|
Thank you! That's even better. |
|
@flobernd are you going to create a new release with this change this week? |
|
@gpetrou Yes, there will be a release this week. Not sure about the exact day yet. |
flobernd
pushed a commit
that referenced
this pull request
Jan 13, 2025
flobernd
added a commit
that referenced
this pull request
Jan 13, 2025
) Co-authored-by: gpetrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare occasions, we are observing
System.ArgumentException: An item with the same key has already been added. at System.Runtime.CompilerServices.ConditionalWeakTable``2.Add(TKey key, TValue value)when adding entries toSettingsTable.I added a lock similar to https://github.com/elastic/apm-agent-dotnet/blob/c4c0649dc18ad15fd89f9a878db8c1b80a103dab/src/Elastic.Apm/Logging/ScopedLogger.cs#L15 to address this issue.