Fixing indices create partially

[l-trotta]

The missing validated tests are either:

• wrong tests IMO, will provide a fix in the flight recorder
• new features (bbq_ivf is still very experimental, since even the name could change I don't think it should be added yet)
• validation bugs

Details:

• IcuCollationTokenFilter's fields are actually snakeCase and not camel_case -> server code
• HunspellTokenFilter: locale has two aliases, and if it's set as mandatory as it was before, this means that the generator will generate 3 mandatory fields. For now I'm setting this as optional, but maybe we should support this as a feature?
• PatternReplaceTokenFilter was missing the flags field -> server code
• In EdgeNGramTokenizer, token_chars can also be expressed as a csv, so making it a string | enum union
• RankVectorProperty was missing -> server code
• FlattenedProperty was missing time_series_dimensions -> server code
• AggregateMetricDoubleProperty was missing ignore_malformed -> server code
• GeoPointProperty was missing time_series_metric -> server code
• Storage in IndexSettings was missing stats_refresh_interval, but I also noticed that in the code and yaml tests there was no trace of the type field, nor the StorageType enum, so maybe we can remove that. -> server code

[github-actions]

Following you can find the validation changes for the APIs you have modified.

API	Status	Request	Response
indices.create	🔴	1246/1306 → 1269/1306	1306/1306
indices.put_mapping	🔴	139/143 → 140/143	146/146

You can validate these APIs yourself by using the make validate target.

[pquentin]

Great job, thank you! In TokenFilterDefinition, persian_stem is missing. I think it's a newish stemmer.

[pquentin]

HunspellTokenFilter: locale has two aliases, and if it's set as mandatory as it was before, this means that the generator will generate 3 mandatory fields. For now I'm setting this as optional, but maybe we should support this as a feature?

Which generator? I think we should discuss this before making it wrongly optional

[l-trotta]

ah sorry wrong wording, I mean the ts compiler. if you look at

elasticsearch-specification/output/typescript/types.ts

Line 4804 in cdaa4ef

export interface AnalysisHunspellTokenFilter extends AnalysisTokenFilterBase {

you'll see the generated output

[pquentin]

Right aliases seem to be a recipe for problem, as their generation is pretty naive. I added a comment to #4599 (comment) to mention it. In the meantime, making this optional just because we can't handle it still seems wrong.

[l-trotta]

okay, reverting then

[pquentin]

This is a technical preview feature, how can we specify it?

[l-trotta]

could this work? since type is the internal tag

export class RankVectorProperty extends PropertyBase {
  /**
   * @availability stack since=8.18.0 stability=experimental
   */
  type: 'rank_vectors'
  element_type?: RankVectorElementType
  dims?: integer
}

[pquentin]

Actually, I don't think that is possible today, see #2830. Leaving this for future work then.

[pquentin]

Can we add a comment at least?

[pquentin]

I can see it here: https://github.com/elastic/elasticsearch/blob/1ad6dbc5991b77ce1b05d5015e1f5ac758e1fcb4/server/src/main/java/org/elasticsearch/index/IndexModule.java#L427-L432