Fixing indices create partially #4652
Conversation
|
Following you can find the validation changes for the APIs you have modified.
You can validate these APIs yourself by using the |
| * @aliases lang, language */ | ||
| locale: string | ||
| locale?: string |
There was a problem hiding this comment.
HunspellTokenFilter: locale has two aliases, and if it's set as mandatory as it was before, this means that the generator will generate 3 mandatory fields. For now I'm setting this as optional, but maybe we should support this as a feature?
Which generator? I think we should discuss this before making it wrongly optional
There was a problem hiding this comment.
ah sorry wrong wording, I mean the ts compiler. if you look at
you'll see the generated output| export class RankVectorProperty extends PropertyBase { | ||
| type: 'rank_vectors' | ||
| element_type?: RankVectorElementType | ||
| dims?: integer | ||
| } | ||
|
|
There was a problem hiding this comment.
This is a technical preview feature, how can we specify it?
There was a problem hiding this comment.
could this work? since type is the internal tag
export class RankVectorProperty extends PropertyBase {
/**
* @availability stack since=8.18.0 stability=experimental
*/
type: 'rank_vectors'
element_type?: RankVectorElementType
dims?: integer
}
There was a problem hiding this comment.
Actually, I don't think that is possible today, see #2830. Leaving this for future work then.
There was a problem hiding this comment.
Can we add a comment at least?
| @@ -534,44 +534,15 @@ export class SlowlogTresholdLevels { | |||
| } | |||
|
|
|||
| export class Storage { | |||
| type: StorageType | |||
There was a problem hiding this comment.
The missing validated tests are either:
Details:
IcuCollationTokenFilter's fields are actually snakeCase and not camel_case -> server codeHunspellTokenFilter:localehas two aliases, and if it's set as mandatory as it was before, this means that the generator will generate 3 mandatory fields. For now I'm setting this as optional, but maybe we should support this as a feature?PatternReplaceTokenFilterwas missing theflagsfield -> server codeEdgeNGramTokenizer, token_chars can also be expressed as a csv, so making it astring | enumunionRankVectorPropertywas missing -> server codeFlattenedPropertywas missingtime_series_dimensions-> server codeAggregateMetricDoublePropertywas missingignore_malformed-> server codeGeoPointPropertywas missingtime_series_metric-> server codeStorageinIndexSettingswas missingstats_refresh_interval, but I also noticed that in the code and yaml tests there was no trace of thetypefield, nor theStorageTypeenum, so maybe we can remove that. -> server code