[compiler] Include exceptions to schema #4695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
approved these changes
Jun 26, 2025
| @@ -211,8 +211,10 @@ pub fn expand(model: IndexedModel, config: ExpandConfig) -> anyhow::Result<Index | |||
|
|
|||
| expand_behaviors(&mut resp.behaviors, &mappings, model, ctx)?; | |||
| expand_body(&mut resp.body, &mappings, model, ctx)?; | |||
|
|
|||
| // TODO: exceptions | |||
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
* compiler: validate types found only in exceptions * split indices.get_alias for clarity, handle NotFoundAliases with previous comit * making the compiler linter happy again * align generics expansion between rust and typescript * compiler: propagate generics in case someone want to have a generic exception * once again, making the linter happy (cherry picked from commit 1c2d7f3)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
* compiler: validate types found only in exceptions * split indices.get_alias for clarity, handle NotFoundAliases with previous comit * making the compiler linter happy again * align generics expansion between rust and typescript * compiler: propagate generics in case someone want to have a generic exception * once again, making the linter happy (cherry picked from commit 1c2d7f3)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
* compiler: validate types found only in exceptions * split indices.get_alias for clarity, handle NotFoundAliases with previous comit * making the compiler linter happy again * align generics expansion between rust and typescript * compiler: propagate generics in case someone want to have a generic exception * once again, making the linter happy (cherry picked from commit 1c2d7f3)
github-actions bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
* compiler: validate types found only in exceptions * split indices.get_alias for clarity, handle NotFoundAliases with previous comit * making the compiler linter happy again * align generics expansion between rust and typescript * compiler: propagate generics in case someone want to have a generic exception * once again, making the linter happy (cherry picked from commit 1c2d7f3)
Anaethelion
added a commit
that referenced
this pull request
Jun 27, 2025
* compiler: validate types found only in exceptions * split indices.get_alias for clarity, handle NotFoundAliases with previous comit * making the compiler linter happy again * align generics expansion between rust and typescript * compiler: propagate generics in case someone want to have a generic exception * once again, making the linter happy (cherry picked from commit 1c2d7f3) Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Jun 27, 2025
* compiler: validate types found only in exceptions * split indices.get_alias for clarity, handle NotFoundAliases with previous comit * making the compiler linter happy again * align generics expansion between rust and typescript * compiler: propagate generics in case someone want to have a generic exception * once again, making the linter happy (cherry picked from commit 1c2d7f3) Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Jun 27, 2025
* compiler: validate types found only in exceptions * split indices.get_alias for clarity, handle NotFoundAliases with previous comit * making the compiler linter happy again * align generics expansion between rust and typescript * compiler: propagate generics in case someone want to have a generic exception * once again, making the linter happy (cherry picked from commit 1c2d7f3) Co-authored-by: Laurent Saint-Félix <[email protected]>
Anaethelion
added a commit
that referenced
this pull request
Jun 27, 2025
* compiler: validate types found only in exceptions * split indices.get_alias for clarity, handle NotFoundAliases with previous comit * making the compiler linter happy again * align generics expansion between rust and typescript * compiler: propagate generics in case someone want to have a generic exception * once again, making the linter happy (cherry picked from commit 1c2d7f3) Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types only found in exceptions are not included in the final
schema.jsonbecause the compiler has not "seen" them.This fixes the
NotFoundAliasesexception present inindices.get_alias.This adds the following to the output:
{ "kind": "interface", "name": { "name": "IndexAliases", "namespace": "indices.get_alias._types" }, "properties": [ { "name": "aliases", "required": true, "type": { "kind": "dictionary_of", "key": { "kind": "instance_of", "type": { "name": "string", "namespace": "_builtins" } }, "singleKey": false, "value": { "kind": "instance_of", "type": { "name": "AliasDefinition", "namespace": "indices._types" } } } } ], "specLocation": "indices/get_alias/_types/response.ts#L24-L26" }, { "kind": "interface", "attachedBehaviors": [ "AdditionalProperties" ], "behaviors": [ { "generics": [ { "kind": "instance_of", "type": { "name": "string", "namespace": "_builtins" } }, { "kind": "instance_of", "type": { "name": "IndexAliases", "namespace": "indices.get_alias._types" } } ], "type": { "name": "AdditionalProperties", "namespace": "_spec_utils" } } ], "name": { "name": "NotFoundAliases", "namespace": "indices.get_alias._types" }, "properties": [ { "name": "error", "required": true, "type": { "kind": "instance_of", "type": { "name": "string", "namespace": "_builtins" } } }, { "name": "status", "required": true, "type": { "kind": "instance_of", "type": { "name": "number", "namespace": "_builtins" } } } ], "specLocation": "indices/get_alias/_types/response.ts#L28-L33" },