Skip to content

Add temporary LegacyActionRequest #128107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented May 16, 2025

In order to remove ActionType, ActionRequest will become strongly typed, referring to the ActionResponse type. As a precursor to that, this commit adds a LegacyActionRequest which all existing ActionRequest implementations now inherit from. This will allow adding the ActionResponse type to ActionRequest in a future commit without modifying every implementation at once.

In order to remove ActionType, ActionRequest will become strongly typed,
referring to the ActionResponse type. As a precursor to that, this
commit adds a LegacyActionRequest which all existing ActionRequest
implementations now inherit from. This will allow adding the
ActionResponse type to ActionRequest in a future commit without
modifying every implementation at once.
@rjernst rjernst requested review from ldematte and DaveCTurner May 16, 2025 19:37
@rjernst rjernst requested a review from a team as a code owner May 16, 2025 19:37
@rjernst rjernst added the :Core/Infra/Transport API Transport client API label May 16, 2025
@rjernst rjernst requested a review from a team as a code owner May 16, 2025 19:37
@rjernst rjernst added >refactoring auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 labels May 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 16, 2025
@rjernst
Copy link
Member Author

rjernst commented May 16, 2025

Note: this PR was created almost entirely through structural search and replace in Intellij.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Transport API Transport client API >refactoring Team:Core/Infra Meta label for core/infra team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants