Retrievers - Fix rank_window_size validation #128108
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a negative
rank_window_size
to a compound retriever, we return an error message that referencessize
instead ofrank_window_size
:Response:
This is coming from:
elasticsearch/server/src/main/java/org/elasticsearch/search/builder/SearchSourceBuilder.java
Lines 517 to 519 in f0d7ec4
This validation needs to happen at the compound retriever level.
Besides fixing the error message, I also moved
rankWindowSize
to the base class for compound retrievers, instead of having it duplicated in 3 inherited retrievers.