Fix union types in CCS #128111
Open
Fix union types in CCS #128111
+69
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dnhatn, I've created a changelog YAML for you. |
dnhatn
force-pushed
the
fix-ccs-multi-types
branch
from
0733fc0 to
954e580
Compare
|
Hi @dnhatn, I've created a changelog YAML for you. |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
dnhatn
commented
May 18, 2025
| @@ -157,7 +157,8 @@ private BlockLoader getBlockLoaderFor(int shardId, Attribute attr, MappedFieldTy | |||
| BlockLoader blockLoader = shardContext.blockLoader(getFieldName(attr), isUnsupported, fieldExtractPreference); | |||
| MultiTypeEsField unionTypes = findUnionTypes(attr); | |||
| if (unionTypes != null) { | |||
| String indexName = shardContext.ctx.index().getName(); | |||
| // Use the fully qualified name `cluster:index-name` because multiple types are resolved on coordinator with the cluster prefix | |||
| String indexName = shardContext.ctx.getFullyQualifiedIndex().getName(); | |||
nik9000
approved these changes
May 19, 2025
| } | ||
|
|
||
| static boolean canUseRemoteIndicesOnly() { | ||
| return dataLocation == DataLocation.REMOTE_ONLY && Clusters.bwcVersion().onOrAfter(Version.V_9_1_0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, union types in CCS is broken. For example,
FROM *:remote-indices | EVAL port = TO_INT(port)returns all nulls if the types of theportfield conflict. This happens because converters are a map of the fully qualifiedcluster:index -name(defined in MultiTypeEsField), but we are looking up the converter using only the index name, which leads to a wrong or missing converter on remote clusters. Our tests didn't catch this because MultiClusterSpecIT generates the same index for both clusters, allowing the local converter to be used for remote indices.