Skip to content

[8.19] Add Mistral AI Chat Completion support to Inference Plugin (#128538) #128947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 9, 2025
Merged

[8.19] Add Mistral AI Chat Completion support to Inference Plugin (#128538) #128947

merged 8 commits into from
Jun 9, 2025

Conversation

Jan-Kazlouski-elastic
Copy link
Contributor

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@Jan-Kazlouski-elastic Jan-Kazlouski-elastic mentioned this pull request Jun 5, 2025
Merged
6 tasks
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v8.19.0 labels Jun 5, 2025
Jan-Kazlouski-elastic
Jan-Kazlouski-elastic commented Jun 6, 2025
View reviewed changes
server/src/main/java/org/elasticsearch/TransportVersions.java Outdated
@@ -235,6 +235,7 @@ static TransportVersion def(int id) {
public static final TransportVersion JOIN_ON_ALIASES_8_19 = def(8_841_0_42);
public static final TransportVersion ILM_ADD_SKIP_SETTING_8_19 = def(8_841_0_43);
public static final TransportVersion ESQL_REGEX_MATCH_WITH_CASE_INSENSITIVITY_8_19 = def(8_841_0_44);
public static final TransportVersion ML_INFERENCE_MISTRAL_CHAT_COMPLETION_ADDED_8_19 = def(8_841_0_45);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the comment from @bpintea left here: #128979 (comment)
TransportVersion for Mistral Completion changes was deleted.
So I'm adding version to TransportVersion as number that doesn't match initial version from main branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jan-Kazlouski-elastic can you open a PR that only adds the transport version ML_INFERENCE_MISTRAL_CHAT_COMPLETION_ADDED_8_19 to main? I think we need to reserve it there first and then once we merge that PR we can set the correct value in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry just saw this: https://github.com/elastic/elasticsearch/pull/129033/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged latest changes from 8.19 so it could be merged quicker if approved.

@Jan-Kazlouski-elastic Jan-Kazlouski-elastic mentioned this pull request Jun 6, 2025
Merged
6 tasks
@Jan-Kazlouski-elastic
Copy link
Contributor Author

Jan-Kazlouski-elastic commented Jun 6, 2025 •
edited
Loading

Hello @jonathan-buttner
Could you please:

  1. Add yourself as assignee.
  2. Add missing labels
  3. Validate failing "Check changelog" task that is asking for a changelog with number of this PR and not original PR. I checked previous backport PR for HuggingFace created by you and it had changelog with number of original PR.
  4. Check this PR: Add transport version for ML inference Mistral chat completion #129033 created to add the TransportVersion to main branch that was deleted by @bpintea
  5. Merge if everything is ok

@jonathan-buttner jonathan-buttner self-assigned this Jun 6, 2025
@jonathan-buttner jonathan-buttner added backport and removed needs:triage Requires assignment of a team area label labels Jun 6, 2025
jonathan-buttner
jonathan-buttner reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍 , once we get the transport version merged to main I think we can merge this.

@Jan-Kazlouski-elastic
Copy link
Contributor Author

Updated PR according to #129033.
Also since #129142 is not in yet - added its TransportVersion as well because it is crucial to have TransportVersion from 8.19 matching the one from main.
FYI @jimczi @jonathan-buttner

@Jan-Kazlouski-elastic
Merge remote-tracking branch 'upstream/8.19' into backport/8.19/pr-12…
7af427c 
…8538

# Conflicts:
#	server/src/main/java/org/elasticsearch/TransportVersions.java
@Jan-Kazlouski-elastic
Copy link
Contributor Author

Updated PR with changes from #129142 as they got merged. Let's wait for the build. There was some CI pipeline instability I believe.

@jimczi
Copy link
Contributor

jimczi commented Jun 9, 2025

#129142 is merged in 8.19, sorry for the trouble

@jonathan-buttner jonathan-buttner merged commit d1c317e into elastic:8.19 Jun 9, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

Assignees

@jonathan-buttner jonathan-buttner

Labels
backport external-contributor Pull request authored by a developer outside the Elasticsearch team v8.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jan-Kazlouski-elastic @jimczi @jonathan-buttner @elasticsearchmachine